Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken RSS links #206

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

bmispelon
Copy link
Member

Fixes #204

Trac itself uses `referer`, so this change makes it easier
to integrate with some other Trac functionalities.
@bmispelon bmispelon mentioned this pull request Jun 29, 2024
@bmispelon bmispelon force-pushed the issue/204-fix-rss-links branch from bdedc19 to b151f81 Compare June 29, 2024 11:11
@bmispelon bmispelon force-pushed the issue/204-fix-rss-links branch from b151f81 to d2d3f11 Compare June 29, 2024 11:13
@medmunds
Copy link

This is clever! (Sometimes it really is better to fix the symptom than the cause.)

Is there already a test to ensure "referer" can't be used as an open redirect exploit?

@bmispelon
Copy link
Member Author

Is there already a test to ensure "referer" can't be used as an open redirect exploit?

Very good question, thanks for thinking about that. We do have a test that should cover everything:

def test_login_valid_with_malicious_redirection(self):

If you can think of a corner-case that's not covered by that test, please send a PR (⚠️ unless you find a case where our site is vulnerable, in which case please email [email protected] instead)

@bmispelon bmispelon merged commit c853691 into django:main Jul 1, 2024
5 checks passed
@bmispelon
Copy link
Member Author

(the fix should be live, let me know how it goes)

@medmunds
Copy link

medmunds commented Jul 1, 2024

Much better. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trac RSS links broken
2 participants