Disabled spamhaus.org antispam check #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
approved these changes
Dec 13, 2024
I meant "temporary" as in "until we remove it from the config again". The changes here will definitely survive reboots/redeploys. Did I misunderstand your proposed resolution from the ticket? |
|
I just meant, I'm not sure we need to try to fix the underlying problem and add the list back. |
Ah I see, yeah that's a good point. Ideally I'd like to fix the underlying issue, but if disabling I'll change the wording not to mention the fix being temporary 👍🏻 |
The service doesn't seem to work, possibly because of the containerization. Refs django#245
bmispelon
force-pushed
the
issue245-disable-spamhaus
branch
from
6a60720 to
623aeb4
Compare
carltongibson
approved these changes
Dec 13, 2024
bmispelon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service doesn't seem to work, possibly because
of the containerization.
Refs #245