Subsidiary changes necessary for forking processes and handling connections.#99
Draft
Subsidiary changes necessary for forking processes and handling connections.#99
Conversation
This does not yet implement proper handling of sequence numbers. That is a fairly significant refactor which should be done as part of the patches for the encryption/decryption channels.
This makes the packet type available on all messages, simplifying error handling downstream as it no longer needs to deal with the anomalous case of a completely empty packet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the merger #87 and #90.
The interesting parts for session forking (without command handling: see followup PR #100 for that) are in
src/main.rsandsrc/monitor.rsandsrc/fd.rs.There are also a lot of other changes squashed in 49fc00e; together with #100 this would essentially bring main identical to the main of trifectatechfoundation/oxish-addons. For a more complete commit history consult that repository. I've spun the changes out into two seperate PR's to isolate the general changes (this PR) and the particular code necessary for running commands and opening a PTY (#100)
Generally this PR shows the work needed for bring the repo (after merging #87 and #90) to a point where terminal handling could be added.