-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement persist #14
Open
youbitchoc
wants to merge
4
commits into
djpohly:main
Choose a base branch
from
youbitchoc:persist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@youbitchoc, are you interested in working on this again? |
@sevz17 sure, why not |
Thanks. |
sevz17
reviewed
Aug 24, 2023
cleaner and more efficient, downside is "Alarm clock" message on stderr that idk how to disable
sevz17
reviewed
Aug 24, 2023
sevz17
suggested changes
Aug 25, 2023
no more "Alarm clock" message on stderr
Now looks pretty good, tomorrow will continue with #10, currently I am so sleepy, going to sleep :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slightly scuffed C code
dunno if I should use a new
end-of-stdin
bool instead of using different int status codes forrun_display
also dunno about duplicating the display loop code but if-casing everything seems like quite a hassle
please let me know how to improve it