Add configuration option for enabling and disabling module signing #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Argh, apparently Github makes it unreasonably difficult to enable the CI tests for a fork. Figured it out now, thankfully, will run the tests in my fork. |
In some situations (such as when building a redistributable system image), it is desirable to suppress module signing and the generation of a Machine Owner Key, even if the system supports module signing. Introduce a new configuration option, "try_sign_modules", which allows one to explicitly enable or disable the module signing system. As publicly redistributable images are often built in a chroot, and should virtually never have a MOK generated at image build time, disable module signing by default when running in a chroot. Fixes: dkms-project#574
ArrayBolt3
force-pushed
the
arraybolt3/try_sign_modules
branch
from
60f947d to
71c0a05
Compare
Member
|
Thank you! |
Contributor
Author
|
Just did the remaining manual testing by installing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations (such as when building a redistributable system image), it is desirable to suppress module signing and the generation of a Machine Owner Key, even if the system supports module signing. Introduce a new configuration option, "try_sign_modules", which allows one to explicitly enable or disable the module signing system. As publicly redistributable images are often built in a chroot, and should virtually never have a MOK generated at image build time, disable module signing by default when running in a chroot.
Fixes: #574
(Note: This is entirely untested so far, I intend on testing it manually and am hoping that submitting this as a PR will trigger the CI to test it. My experience with Github Actions is lacking...)