Evolving the syntax of PLS_*
macros.
#13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @amdrozdov !
So this works. I have added:
PLS_INCLUDE_HEADER_ONLY_CURRENT()
-- self-explanatory,PLS_ADD(dst,repo)
-- will clonerepo
as the directorydst
,PLS_DEP(lib)
-- will add the depencency, andPLS_ADD_DEP(lib,repo)
-- will both clone and add the dependency, and it requires that the dependency name is the same as the name of the lib.This enables:
Ultimately,
PLS_IMPORT
is being deprecated. And we will addPLS_ADD_CURRENT_DEP(name)
, as a shortcut forcurrent-deps/*
, since every library (or at least most libraries) incurrent-deps
will expose one (main) library, with the name matching the name of the repo.Hope this works for you. Good to merge from my end!
Thanks,
Dima
Work in progress as of now, I will update this message once the PR is ready to review & merge.