Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolving the syntax of PLS_* macros. #13

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Evolving the syntax of PLS_* macros. #13

merged 9 commits into from
Aug 6, 2024

Conversation

dkorolev
Copy link
Owner

@dkorolev dkorolev commented Aug 6, 2024

Hi @amdrozdov !

So this works. I have added:

  • PLS_INCLUDE_HEADER_ONLY_CURRENT() -- self-explanatory,
  • PLS_ADD(dst,repo) -- will clone repo as the directory dst,
  • PLS_DEP(lib) -- will add the depencency, and
  • PLS_ADD_DEP(lib,repo) -- will both clone and add the dependency, and it requires that the dependency name is the same as the name of the lib.

This enables:

PLS_ADD("wsServer", "https://github.com/current-deps/wsServer.git");
PLS_DEP("ws");

Ultimately, PLS_IMPORT is being deprecated. And we will add PLS_ADD_CURRENT_DEP(name), as a shortcut for current-deps/*, since every library (or at least most libraries) in current-deps will expose one (main) library, with the name matching the name of the repo.

Hope this works for you. Good to merge from my end!

Thanks,
Dima

Work in progress as of now, I will update this message once the PR is ready to review & merge.

@dkorolev dkorolev self-assigned this Aug 6, 2024
@dkorolev
Copy link
Owner Author

dkorolev commented Aug 6, 2024

(The force-pushes are me rebasing the safe_readlink() commit into this one.)

@dkorolev dkorolev requested a review from amdrozdov August 6, 2024 13:19
@dkorolev dkorolev removed their assignment Aug 6, 2024
Copy link
Collaborator

@amdrozdov amdrozdov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amdrozdov amdrozdov merged commit 331e358 into main Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants