-
Couldn't load subscription status.
- Fork 20
API Improvements #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
API Improvements #256
Conversation
Still contains some "trusted" annotations due to whacky inout semantics, but provides the basis for making the rest of the codebase "safe".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
| return dst.data; | ||
| } | ||
|
|
||
| void renderParameters(DdocContext context, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused or undocumented public API
Should this rather return a helper struct that you can foreach on to be more idiomatic? (e.g. opApply)
source/ddox/ddoc.d
Outdated
|
|
||
| bool hasSection(string name) const { return m_sections.canFind!(s => s.name == name); } | ||
|
|
||
| const(string)[] getRawSectionContent(string name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused or undocumented public API
|
@WebFreak001: I was focused on making the additional information available consistently with the existing code, but you are right that the current API is not very good. My suggestion for I'm not sure about the |
Allows to get the unprocessed Ddoc string for sections in order to support custom special use sections (e.g. "Category:") that are not supposed to be rendered.
Adds the possibility for more fine-grained rendering of the "Params" section in cases where the name/description table layout is undesirable.
eff07e8 to
4f7329a
Compare
Makes the entity module API
@safeto make it better suited for web app embedding and adds more fine-grained access to Ddoc section contents.