Use fileOffset in generateIdWithLoc #20897
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the GC string concatenation, and use
loc.fileOffset
instead, which is more robust since it doesn't get affected by#line
directives (which a preprocessed ImportC file tends to have a lot of). Unfortunately many tests still expose the internal name, but I made the ones which can't beAUTO_UPDATE
'd less reliant on hard-coded line/column numbers.