Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fileOffset in generateIdWithLoc #20897

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Feb 18, 2025

Remove the GC string concatenation, and use loc.fileOffset instead, which is more robust since it doesn't get affected by #line directives (which a preprocessed ImportC file tends to have a lot of). Unfortunately many tests still expose the internal name, but I made the ones which can't be AUTO_UPDATE'd less reliant on hard-coded line/column numbers.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20897"

@dkorpel dkorpel marked this pull request as draft February 19, 2025 00:19
@dkorpel
Copy link
Contributor Author

dkorpel commented Feb 19, 2025

Still todo: deal with mixins creating duplicate locations

void main()
{
    auto z0 = mixin("(() => 3)()");
    auto z1 = mixin("(() => 4)()");
    assert(z0 == 3);
    assert(z1 == 4);
}

And see what to do about buildkite failures from projects testing for hard-coded unittest_LXX_CXX strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants