Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted Dsymbol.oneMember to a visitor in dsymbolsem #20915

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

MatthewQiu-5
Copy link
Contributor

@MatthewQiu-5 MatthewQiu-5 commented Feb 25, 2025

Part of the project to separate semantic routines from AST nodes. @RazvanN7

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MatthewQiu-5! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20915"

@MatthewQiu-5 MatthewQiu-5 force-pushed the attrib_sema1 branch 2 times, most recently from 0dde7d4 to bae21f4 Compare February 25, 2025 08:11
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This otherwise looks good

* true, ps = null: There are zero symbols
* true, ps = symbol: The one and only one symbol
*/
extern(C++) bool oneMember(Dsymbol d, out Dsymbol ps, Identifier ident)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused by LDC/GDC remove the extern(C++), this is causing CircleCI to fail because the generated frontend.h doesn't match.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, I'll go ahead and remove extern(C++).

@thewilsonator thewilsonator merged commit 996acb0 into dlang:master Feb 25, 2025
29 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants