-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracted Dsymbol.oneMember to a visitor in dsymbolsem #20915
Conversation
Thanks for your pull request and interest in making D better, @MatthewQiu-5! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#20915" |
0dde7d4
to
bae21f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This otherwise looks good
compiler/src/dmd/dsymbolsem.d
Outdated
* true, ps = null: There are zero symbols | ||
* true, ps = symbol: The one and only one symbol | ||
*/ | ||
extern(C++) bool oneMember(Dsymbol d, out Dsymbol ps, Identifier ident) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unused by LDC/GDC remove the extern(C++)
, this is causing CircleCI to fail because the generated frontend.h
doesn't match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, I'll go ahead and remove extern(C++).
bae21f4
to
01ae9e2
Compare
Part of the project to separate semantic routines from AST nodes. @RazvanN7