Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more work on variadic functions #20918

Merged
merged 1 commit into from
Feb 28, 2025
Merged

more work on variadic functions #20918

merged 1 commit into from
Feb 28, 2025

Conversation

WalterBright
Copy link
Member

No description provided.

@WalterBright WalterBright added Compiler:Backend glue code, optimizer, code generation Arch:Aarch64 Issues specific to Arm 64 labels Feb 27, 2025
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20918"

dkorpel
dkorpel reviewed Feb 27, 2025
View reviewed changes
compiler/src/dmd/backend/arm/cod3.d
Comment on lines +341 to +342
printf("voff: %llx offset: %x\n", voff, offset);
offset &= 0xFFF; // TODO AArch64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR ready?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The stack frame isn't being set up correctly, which is a problem elsewhere in the code generator. It all has to be working for runnable programs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asking because there's debug printf's, unindented lines, and tabs in the PR. Do you want to fix those?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use the TODO tag so I don't forget things.

dkorpel
dkorpel approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you'll fix the indentation and printf's at some point

@WalterBright WalterBright merged commit ebb0bf6 into dlang:master Feb 28, 2025
40 of 42 checks passed
@WalterBright
Copy link
Member Author

The 0 indentation I use to indicate a temporary hack. The printf will go when I'm satisfied with its operation.

@WalterBright WalterBright deleted the variadic2 branch February 28, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkorpel dkorpel dkorpel approved these changes

Assignees
No one assigned
Labels
Arch:Aarch64 Issues specific to Arm 64 Compiler:Backend glue code, optimizer, code generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WalterBright @dlang-bot @dkorpel