Skip to content

Conversation

@everhart
Copy link

@everhart everhart commented Jul 2, 2025

Currently, the install script is failing because gpg is unable to verify signatures for the dlang-installer, and dmd. This is with fresh gpg keys downloaded by the install script. Seeing as I can't upload up-to-date keys myself, to remedy this I added a "-f,--force" option to the install script. If used, it warns the user signature verification is disabled, and does not perform signature verification.

I'm not overly concerned about a malicious actor bypassing my computer's security by giving me a malignant D installer, so I would like to have this option as a workaround when the D keyring is out of date.

This serves as a workaround for Issue #715. I didn't mark it as a fix, as it is merely a workaround, and not a fix.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @everhart! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@CyberShadow
Copy link
Member

I'm not overly concerned about a malicious actor bypassing my computer's security by giving me a malignant D installer, so I would like to have this option as a workaround when the D keyring is out of date.

That doesn't accurately represent the danger - it could be any actor that can make your computer think it's connecting to dlang.org. This could be anyone who is capable of MITM (e.g. if they obtain a leaked trusted root certificate private key), or anyone who can access the website (e.g. by compromising the server, stealing credentials, or abusing granted privileges).

--force is almost never a good name due to inherent ambiguity, and it's especially not a good name in this situation. Consider instead --insecure-disable-integrity-check (with no short alias).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants