Implement DualMatrix to be able to solve 2nd order problems#26
Open
max-vassili3v wants to merge 17 commits intodlfivefifty:mainfrom
Open
Implement DualMatrix to be able to solve 2nd order problems#26max-vassili3v wants to merge 17 commits intodlfivefifty:mainfrom
max-vassili3v wants to merge 17 commits intodlfivefifty:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 70.87% 71.87% +1.00%
==========================================
Files 5 5
Lines 103 128 +25
==========================================
+ Hits 73 92 +19
- Misses 30 36 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a minimal implementation of
DualMatrixso that we are able to do 2nd order differentiation (as shown by the example in the unit tests) by allowingDualVectors with aDualVectorvalue and aDualMatrixjacobian, thus being able to create 'nested dual arrays'. That can propagate higher order derivatives. We have:DualMatrixNext steps:
DualMatrixfully functional and behave as expected with existing types (DualMatrix-DualVectormultiplication, reshape, etc.)