Adds discriminated union for VTree (VComp | VNode | VText) #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refines VTree to VComp | VNode | VText
- Adjust hydrate.ts / dom.ts to reflect types (as cast)
- Adds smart constructor for VComp (vcomp)
- Removes unsafe 'domRef: any' in favor of union DOMRef (HTML | SVG | MATHML)
- Refines vcomp tag to 'div' (always) and domRef: HTMLElement (always)
- Refines domRef to Text for VText
- Adjusts tests to use vcomp smart constructor
- Adds "ns" field for VText, Haskell side.
- Refines mount callback to VComp in dom.ts
- Factors out "preamble" function for hydration
- Intros and exports NS type ('html' | 'svg' | 'mathml')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VTreetoVComp | VNode | VTexthydrate.ts/dom.tsto reflect types (as cast)VComp(vcomp)domRef: anyin favor of uniontype DOMRef = HTML | SVG | MathMLvcomptagto'div'(always) anddomRef: HTMLElement(always)domReftoTextforVTextvcompsmart constructorVText, Haskell side.VCompindom.tspreamblefunction for pre-walkactivities inhydration.tsNStype'html' | 'svg' | 'mathml'