Add production flag for production-grade JS #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds 'bun build --production' for `miso.prod.js` - Make `miso-prod-js` derivation. - Re-add `js/miso.js`, `js/miso.prod.js` to git - Add CPP for production flag (not default), for saddle workflows - Add `build-prod` to package.json - Put `bun run build-prod` in CI, along with `miso-prod-js` We have to commit both (prod and dev) js/ "binaries" to source control now. This is because GitHub users that fetch miso from a `cabal.project` need the js present. Adding the production flag is a bonus.
|
This one is for you @mastarija |
Thanks man. I got it twerking ;)
|
|
Well done 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bun build --productionto createjs/miso.prod.jsmiso-prod-jsderivation.js/miso.js,js/miso.prod.js"binaries" togitbuild-prodto package.jsonbun run build-prodin CI, along withmiso-prod-jsWe have to commit both (prod
js/miso.prod.jsand devjs/miso.js) "binaries" to source control now. This is because GitHub users that fetchmisofromcabal.projectneed the js present in order to build. Adding the production flag is a bonus, but this will work with.