Repository navigation
Fix native binary cache misses on Depot runners - #1205
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed the native cache lookup extraction, dependent build conditions, and preview runner change in .github/workflows/test.yaml against the existing cache producers and Depot's documented routing behavior.
- GitHub-hosted cache checks: Moves lookup-only checks into
native-cache-check, preserving source-change gating and the shared Rust source hash. - Native build dependencies: Updates both native build callers to consume the new job's cache-hit outputs.
- Preview cache restores: Runs preview publishing on GitHub-hosted Ubuntu while retaining the separate Depot Turbo cache configuration.
CI passed, but the native cache and preview jobs were skipped on this workflow-only PR, so the live cache-hit and publication paths remain untested here.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Since #1184, every PR that releases
varlockrebuilds (and signs) the macOS app and the Rust helpers on every push.The native build jobs run on GitHub runners and save the binaries to GitHub's Actions cache. The cache lookups in
build-and-testand the restores inrelease-preview-packagesnow run on Depot runners, and Depot redirectsactions/cacheto Depot Cache (this redirect isn't affected by the org's automatic cache connection setting), so they always miss.native-cache-checkjob onubuntu-latest.release-preview-packagesmoves back toubuntu-latestso it restores binaries from GitHub's cache. This also keeps the binaries in published preview packages out of Depot's cache, which has no branch isolation.