Skip to content

docs: fix outdated TanStack Start config examples - #1208

Merged
theoephraim merged 2 commits into
dmno-dev:mainfrom
Visualizeit:codex/docs-tanstack-vite-config
Oct 13, 2026
Merged

theoephraim merged 2 commits into
dmno-dev:mainfrom
Visualizeit:codex/docs-tanstack-vite-config

Conversation

@Visualizeit

@Visualizeit Visualizeit commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

The TanStack Start examples still use the removed @tanstack/react-start/config entry point.

Update both Vite and Cloudflare examples to use vite.config.ts, import defineConfig from vite, and move plugins to the top level, matching the current TanStack Start documentation.

Also adds viteEnvironment: { name: 'ssr' } to the Cloudflare example, which TanStack Start on Cloudflare requires (matches our framework-test config).

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: Reviewed both updated TanStack Start configuration examples against the current upstream documentation and the Varlock plugin implementations.

  • Vite setup: Uses vite.config.ts, imports defineConfig from vite, and registers plugins at the config root.
  • Cloudflare setup: Applies the same configuration corrections while preserving the existing plugin calls and ordering.

Validation was limited to documentation and source inspection; no website build or end-to-end example execution was performed.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@theoephraim

Copy link
Copy Markdown
Member

thanks!

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: Reviewed the Cloudflare configuration change since the prior review.

  • Added SSR environment selection: Passed viteEnvironment: { name: 'ssr' } to varlockCloudflareVitePlugin, matching TanStack Start's hosting guide and the repository's framework-test configuration. Verified that the wrapper forwards this option unchanged.

Validation was limited to documentation and source inspection; no website build or end-to-end example execution was performed.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@theoephraim
theoephraim merged commit 48ccf44 into dmno-dev:main Oct 13, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants