Repository navigation
docs: fix outdated TanStack Start config examples - #1208
Merged
theoephraim merged 2 commits intoOct 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed both updated TanStack Start configuration examples against the current upstream documentation and the Varlock plugin implementations.
- Vite setup: Uses
vite.config.ts, importsdefineConfigfromvite, and registers plugins at the config root. - Cloudflare setup: Applies the same configuration corrections while preserving the existing plugin calls and ordering.
Validation was limited to documentation and source inspection; no website build or end-to-end example execution was performed.
gpt-6.1-sol | 𝕏
Member
|
thanks! |
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed the Cloudflare configuration change since the prior review.
- Added SSR environment selection: Passed
viteEnvironment: { name: 'ssr' }tovarlockCloudflareVitePlugin, matching TanStack Start's hosting guide and the repository's framework-test configuration. Verified that the wrapper forwards this option unchanged.
Validation was limited to documentation and source inspection; no website build or end-to-end example execution was performed.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The TanStack Start examples still use the removed
@tanstack/react-start/configentry point.Update both Vite and Cloudflare examples to use
vite.config.ts, importdefineConfigfromvite, and movepluginsto the top level, matching the current TanStack Start documentation.Also adds
viteEnvironment: { name: 'ssr' }to the Cloudflare example, which TanStack Start on Cloudflare requires (matches our framework-test config).