Skip to content

Fix auto-load CLI crash diagnostics and host exit codes - #1210

Merged
theoephraim merged 2 commits into
mainfrom
pullfrog/1209-auto-load-crash-diagnostics
Oct 13, 2026
Merged

theoephraim merged 2 commits into
mainfrom
pullfrog/1209-auto-load-crash-diagnostics

Conversation

@pullfrog

@pullfrog pullfrog Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1209.

  • Map signed and unsigned Windows native crash statuses to host exit code 1, including error-hook and throw-mode exit paths.
  • Report the invoked CLI command and original hexadecimal status or signal, even when the child produces stderr. Retain buffer-limit and timeout causes.
  • Preserve failed stdout and partial resolved values for error hooks without automatically printing JSON that may contain secrets.
  • Vite, Next.js, Cloudflare and Expo integrations also print the crash diagnostic (previously silent when stderr was empty); Next.js builds exit 1 instead of a native crash code.
  • Add regression coverage and document crash reporting.

Verified with the full Varlock suite (2,438 passed, 13 skipped), package typecheck/build, and docs build. Windows statuses are simulated in tests on Linux; the underlying Node Windows assertion was not reproduced.

Pullfrog  | View workflow run | via Pullfrog | Using gpt-6.1-sol | 𝕏

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
varlock-website 7ca7801 Commit Preview URL

Branch Preview URL
Oct 10 2026, 08:08 PM

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

bumpy-frog

The changes in this PR will be included in the next version bump.

patch Patch releases

  • @varlock/astro-integration 1.4.3 → 1.4.4 (cascade)
  • @varlock/cloudflare-integration 1.6.1 → 1.6.2
  • @varlock/expo-integration 1.2.1 → 1.2.2
  • @varlock/native-helper-darwin 1.22.0 → 1.22.1
  • @varlock/native-helper-linux-arm64 1.22.0 → 1.22.1
  • @varlock/native-helper-linux-x64 1.22.0 → 1.22.1
  • @varlock/native-helper-win32-x64 1.22.0 → 1.22.1
  • @varlock/nextjs-integration 1.2.4 → 1.2.5
  • @varlock/nuxt-integration 0.1.3 → 0.1.4 (cascade)
  • @varlock/vite-integration 1.5.3 → 1.5.4
  • varlock 1.22.0 → 1.22.1

Bump files in this PR

Click here if you want to add another bump file to this PR


This comment is maintained by bumpy.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle size

⚠️ grows the bundle by 7.0 KB (+0.1%)

Metric main This PR Δ
Total dist 5066.8 KB 5073.8 KB +7.0 KB (+0.1%)
JS 1917.7 KB 1920.1 KB +2.4 KB (+0.1%)
Sourcemaps 3018.9 KB 3023.2 KB +4.4 KB (+0.1%)
Type defs 130.2 KB 130.5 KB +0.3 KB (+0.2%)
Other 0.0 KB 0.0 KB —

dist/ only; native binaries are versioned separately and not counted here.

@pullfrog

pullfrog Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor Author

The failed check was cache-lock-crossproc.test.ts:137: the cache lock remained after SIGINT, in a code path unchanged by this PR. I could not reproduce it: the exact CI command, bun run test:ci, passed on both the parent commit and PR head (PR Varlock suite: 2,438 passed, 13 skipped), and the cache-lock tests passed 10 repeated runs on the parent. No changes were committed or pushed because no PR-caused regression was established; the working tree is clean. Re-run the failed CI job; if it recurs, investigate the existing cache-lock signal test separately.

Task list (2/3 completed)
  • Checkout PR and inspect CI failure and relevant conventions
  • Confirm whether PR caused failure using parent and PR test runs
  • Implement, commit and push targeted fix

Pullfrog  | View workflow run | via Pullfrog | Using gpt-6.1-sol | 𝕏

@pullfrog

pullfrog Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor Author

The failed TanStack Start check is unrelated to this PR: I reproduced Could not resolve entry module "index.html" in a minimal TanStack project with no Varlock dependency or plugin. The fixture's floating dependency ranges now resolve @tanstack/react-start@1.169.1 and @tanstack/start-plugin-core@1.171.52, which require Vite >=8.0.0, while the failing fixtures use Vite 6 and 7; these fixtures are unchanged by this PR. Per the CI-fix workflow, I made no unrelated changes and pushed no commit; the working tree is clean. A separate fix should pin compatible TanStack dependencies for the Vite 6/7 fixtures.

Task list (1/3 completed)

Pullfrog  | View workflow run | via Pullfrog | Using gpt-6.1-sol | 𝕏

@pkg-pr-new

pkg-pr-new Bot commented Oct 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

varlock

npm i https://pkg.pr.new/varlock@1210

@varlock/astro-integration

npm i https://pkg.pr.new/@varlock/astro-integration@1210

@varlock/cloudflare-integration

npm i https://pkg.pr.new/@varlock/cloudflare-integration@1210

@varlock/expo-integration

npm i https://pkg.pr.new/@varlock/expo-integration@1210

@varlock/nextjs-integration

npm i https://pkg.pr.new/@varlock/nextjs-integration@1210

@varlock/nuxt-integration

npm i https://pkg.pr.new/@varlock/nuxt-integration@1210

@varlock/vite-integration

npm i https://pkg.pr.new/@varlock/vite-integration@1210

@varlock/native-helper-darwin

npm i https://pkg.pr.new/@varlock/native-helper-darwin@1210

@varlock/native-helper-linux-arm64

npm i https://pkg.pr.new/@varlock/native-helper-linux-arm64@1210

@varlock/native-helper-linux-x64

npm i https://pkg.pr.new/@varlock/native-helper-linux-x64@1210

@varlock/native-helper-win32-x64

npm i https://pkg.pr.new/@varlock/native-helper-win32-x64@1210

commit: 4b0915f

@theoephraim
theoephraim merged commit 4600ad2 into main Oct 13, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: auto-load kills the host process with the child's abort exit code (0xC0000409) and no error on Windows

1 participant