Skip to content

Fix TanStack Start framework tests for 1.169 (vite 8 only) - #1224

Merged
theoephraim merged 3 commits into
mainfrom
pin-tanstack-start-vite7
Oct 13, 2026
Merged

theoephraim merged 3 commits into
mainfrom
pin-tanstack-start-vite7

Conversation

@theoephraim

@theoephraim theoephraim commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

@tanstack/react-start 1.169 (via start-plugin-core 1.171.51) raised its vite peer dep to >=8: the plugin now sets client/server entries only in rolldownOptions, so vite 6/7 builds fail with Could not resolve entry module "index.html". This broke every build/preview scenario in the TanStack Start framework tests on main.

  • vite 8 suite tests the latest TanStack Start, and now also runs the nitro target scenarios (moved from vite 7).
  • vite 7 suite stays, pinned to @tanstack/react-start ~1.168.13 (the last line supporting vite 7) via a new tanstackStartVersion option.
  • Drop the vite 6 suite: TanStack Start never supported vite 6 (1.168 already required >=7).

No varlock-relevant behavior changed in 1.169; the diff is the rollup/rolldown option change plus unrelated sitemap, rsbuild and compiler fixes.

… suite

@tanstack/react-start 1.169 requires vite >= 8: its plugin now only sets
rolldownOptions, so vite 7 client builds fail with "Could not resolve entry
module index.html". The vite 8 suite keeps testing the latest release.
TanStack Start never supported vite 6, so that suite is removed.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: Reviewed the TanStack Start framework-test dependency selection and suite coverage, including published upstream dependency metadata and test discovery.

  • Vite 7 compatibility: The new tanstackStartVersion option applies ~1.168.13 consistently to Node, Cloudflare, and Nitro fixtures; the allowed published releases retain Vite 7-compatible plugin dependencies.
  • Vite 8 coverage: The Vite 8 suite keeps the existing caret range to exercise newer Start releases.
  • Unsupported combination removed: The Vite 6 suite is removed without leaving stale test-discovery references; the previously selected Start line already requires Vite 7 or newer.

The TanStack Start framework-test job passed for this head. I did not rerun the suite locally.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

Replaces the 1.168.x pin: drop the vite 7 suite since current TanStack Start
requires vite >= 8, and run the nitro regression scenarios on vite 8.
@theoephraim theoephraim changed the title Fix TanStack Start framework tests: pin 1.168.x for vite 7, drop vite 6 Fix TanStack Start framework tests: test latest on vite 8 only Oct 13, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: Reviewed the changes since 6460c955, including suite discovery, shared dependency selection, and the relocated Nitro regression coverage.

  • Removed Vite 7 coverage: Deleted the older suite and reverted the temporary tanstackStartVersion override, retaining the existing Start caret range for all remaining targets.
  • Moved Nitro coverage to Vite 8: Preserved all five encrypted-environment regression scenarios using the existing pinned Nitro version, now with Vite 8 and React plugin 6.

The TanStack Start framework-test job passed for 71a68d19. I did not rerun the suite locally.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@theoephraim theoephraim changed the title Fix TanStack Start framework tests: test latest on vite 8 only Fix TanStack Start framework tests for 1.169 (vite 8 only) Oct 13, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: Reviewed 71a68d19..318e11e5, including the restored suite, fixture dependency propagation, and published upstream dependency metadata.

  • Restored Vite 7 coverage: Reintroduced Node and Cloudflare scenarios with @tanstack/react-start ~1.168.13; the published releases allowed by this range pin Vite 7-compatible plugin-core versions.
  • Reintroduced the dependency override: Applied the optional Start range consistently across shared fixture definitions without mutating defaults or changing the existing Vite 8 and Nitro coverage.

The TanStack Start framework-test job is still running for this head. I did not rerun the suite locally.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@theoephraim
theoephraim merged commit 0e18146 into main Oct 13, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant