Repository navigation
Run the detached telemetry sender from the temp dir - #1225
Merged
Merged
Conversation
The sender inherited the parent's cwd, and on Windows a process's cwd cannot be removed while it runs, so deleting a project dir right after a command failed with EPERM (Windows smoke tests on main).
Contributor
|
The changes in this PR will be included in the next version bump.
|
Contributor
📦 Bundle size
dist/ only; native binaries are versioned separately and not counted here. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Checked the detached sender's working-directory change, startup paths, and regression coverage.
- Sender working directory: Uses
os.tmpdir()rather than retaining the project directory while background telemetry finishes. - Regression coverage: Updates the spawn-options assertion; all 72 telemetry tests passed. A Bun probe confirmed script re-execution works from the temp directory. Windows-specific directory cleanup was not exercised in this Linux environment.
- Release note: Extends the existing telemetry patch note to describe the directory-lock fix.
gpt-6.1-sol ｜ 𝕏
@env-spec/parser
varlock
@varlock/astro-integration
@varlock/cloudflare-integration
@varlock/expo-integration
@varlock/nextjs-integration
@varlock/nuxt-integration
@varlock/vite-integration
@varlock/native-helper-darwin
@varlock/native-helper-linux-arm64
@varlock/native-helper-linux-x64
@varlock/native-helper-win32-x64
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The detached telemetry sender from #1217 inherited the parent's cwd. On Windows a running process's cwd can't be deleted, so removing a project dir right after a varlock command fails with EPERM. This broke the Windows smoke test cleanup on main (
binary-plugin.test.tsafterAllrmSyncoftmp-multi-plugin), e.g. https://github.com/dmno-dev/varlock/actions/runs/38480730636/job/115582755541.Spawn the sender with
cwd: os.tmpdir().