Skip to content

Pin all GitHub Actions to commit SHAs - #1229

Merged
theoephraim merged 2 commits into
mainfrom
pin-github-actions-sha
Oct 14, 2026
Merged

theoephraim merged 2 commits into
mainfrom
pin-github-actions-sha

Conversation

@theoephraim

Copy link
Copy Markdown
Member

Pins every third-party action in .github/workflows to a full commit SHA with a version comment, instead of mutable tags. A moved tag (as in the tj-actions/changed-files and reviewdog compromises) can no longer change what runs in CI or release jobs.

  • Adds .github/dependabot.yml for the github-actions ecosystem: weekly, grouped into one PR, with a 7-day cooldown before adopting new releases
  • dtolnay/rust-toolchain was on the stable branch; now pinned to a master commit with toolchain: stable passed explicitly
  • Bumps actions to their latest releases while here: cache v6, setup-node v7, labeler v7, azure/login v3 (Node 24), pnpm/action-setup v6.1.0, and unifies stragglers (upload-artifact/download-artifact v4, github-script v7, cache v4, checkout v6) onto the versions used elsewhere
  • pr-labeler now labels dependabot[bot] PRs as bot

Release-only paths (azure/login v3, cache restores in release.yaml) aren't exercised by PR CI and will first run on the next release.

Follow-up: enable the repo setting that requires actions to be pinned to a full-length SHA.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle size

no change to bundle size

Metric main This PR Δ
Total dist 5077.5 KB 5077.5 KB —
JS 1921.5 KB 1921.5 KB —
Sourcemaps 3025.4 KB 3025.4 KB —
Type defs 130.7 KB 130.7 KB —
Other 0.0 KB 0.0 KB —

dist/ only; native binaries are versioned separately and not counted here.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found.

Reviewed changes: Reviewed all workflow and Dependabot changes, verified upstream release-tag SHAs, and checked upgrade compatibility with existing inputs and consumers.

  • Action pins: Replaces mutable action references with full commit SHAs and version comments across CI, release, signing, and automation workflows.
  • Version upgrades: Updates action majors and standardizes artifact/comment actions; preserves Rust stable-toolchain selection through an explicit input.
  • Update automation: Adds weekly grouped Dependabot updates with a seven-day cooldown and labels Dependabot PRs as bot.

Release-only Azure authentication and native cache restores were reviewed statically, not executed; native build and smoke-test jobs were skipped in this PR's CI.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@theoephraim
theoephraim merged commit d5d5f61 into main Oct 14, 2026
22 checks passed
theoephraim added a commit that referenced this pull request Oct 19, 2026
* Pin remaining GitHub Actions to commit SHAs and enforce it in CI

#1226 branched before #1229 and reintroduced tag refs in the macOS binary
build plus two download-artifact steps. Pin those, and add a CI check that
fails on any remote action not pinned to a full SHA with a ref comment.

* Drop custom pin check in favor of GitHub's require-SHA-pinning setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant