Repository navigation
Make Next.js extra env file watchers non-persistent - #1237
Merged
Merged
Conversation
Contributor
|
The changes in this PR will be included in the next version bump.
|
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes across the extra env watcher setup, its regression assertion, and the package release entry.
- Watcher lifetime: Extra env file polling uses
persistent: false, allowing short-lived config-loading processes to exit without changing reload callbacks or polling frequency. - Regression coverage: The existing FIFO test checks that installed watchers are non-persistent.
- Release entry: Records the process-lifetime fix for
@varlock/nextjs-integration.
The integration build and all 57 unit tests passed. A Node subprocess using the built dev-mode loader exited naturally. Full Next.js server reload and telemetry-helper end-to-end scenarios were not run.
gpt-6.1-sol | 𝕏
varlock
@varlock/nextjs-integration
@varlock/native-helper-darwin
@varlock/native-helper-linux-arm64
@varlock/native-helper-linux-x64
@varlock/native-helper-win32-x64
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #1235.
enableExtraFileWatchersused persistentfs.watchFilewatchers, so any process that loads the Next config in dev mode stayed alive forever. Since Next 16.0.3 the telemetrydetached-flushhelper relies on the event loop draining to exit, so everynext devstop left one orphaned process behind.The watchers now pass
persistent: false. The dev server stays alive through its HTTP server, so env reloading is unaffected.