Repository navigation
Put eslint-disable above ts-nocheck in generated types - #1244
Merged
theoephraim merged 1 commit intoOct 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the generated TypeScript header fix and its regression coverage for #1243.
- Comment ordering: Moves
/* eslint-disable */before// @ts-nocheck, preventing@typescript-eslint/ban-ts-commentfrom reporting the generated directive while preserving TypeScript suppression. - Regression coverage: Adds assertions that both directives are present and ordered correctly. All 94 focused type-generation tests passed; the build, changed-file lint, and direct ESLint/TypeScript behavior probes also passed.
- Release entry: Includes a
varlockpatch entry describing the generated-file lint fix.
gpt-6.1-sol | 𝕏
theoephraim
force-pushed
the
eslint-disable-above-ts-nocheck
branch
from
October 29, 2026 06:09
cf1edc4 to
1f0dc52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #1243
the generated
.d.tshad// @ts-nocheckbefore/* eslint-disable */, so a lint rule that flags@ts-nocheck(like@typescript-eslint/ban-ts-comment) still reported that line. the two lines are swapped now, so eslint is off before it.@ts-nocheckstill works there, ts reads it from any of the leading comments (the autogenerated banner was already above it). checked withtsc --stricton a file with that header and a type error: no errors reported.added a check to the existing
generateTsTypesSrc outputtest that the eslint-disable line comes first; it fails on main.