Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed the banner formatting change, its CLI and library callers, the regression test, and the documentation update.
- Error banner: Adds error-state key names in schema order without reading values or changing validation and exit behavior.
- Regression coverage: Checks that the first non-empty stderr line names both failing keys and excludes the valid key; all 23 focused tests passed, along with the Varlock build and changed-file lint check.
- Documentation and release note: Updates the usage example and adds a patch release note describing the diagnostic improvement.
gpt-6.1-sol | 𝕏
Member
|
thanks for the PR! ended up fixing in #1256 with some modifications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #1246
The "Configuration is currently invalid" banner now lists the failing keys on the same line, e.g.
Configuration is currently invalid: DATABASE_URL, API_TOKEN. Tools that keep only the first stderr line of a failed process (container termination reasons, CI annotations, error-tracker titles) now say which variable is wrong. Only key names are added, never values.checkForConfigErrorsappends the failing keys to the banner.error-checks.test.tsloads a real graph with two empty required items and one valid item, and checks the first non-empty stderr line names both failing keys and not the valid one. It fails onmainand passes with the change.getting-started/usage.mdx.Existing smoke and framework tests match the banner with
toContain('Configuration is currently invalid'), so they still match.