Repository navigation
Remove revealSensitiveConfig() - #1268
Open
theoephraim wants to merge 1 commit into
Open
theoephraim wants to merge 1 commit into
theoephraim wants to merge 1 commit into
Conversation
Its in-band unmask marker was a fixed string, so text logged next to a secret could forge it and switch off redaction for that value. Use @sensitive={redact=false} to print a value on purpose.
theoephraim
added
the
BREAKING
Contributor
|
The changes in this PR will be included in the next version bump.
|
Contributor
📦 Bundle size✅ shrinks the bundle by 19.2 KB (−0.4%)
dist/ only; native binaries are versioned separately and not counted here. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed the API removal, redaction behavior, affected exports, documentation, and regression coverage.
- API removal: Removes
revealSensitiveConfig()fromvarlock/env,varlock/auto-init, and Cloudflare init, with major-version release entries. - Redaction simplification: Removes the fixed-marker bypass, output marker stripping, and marker-specific stream holdback while retaining secret redaction and split-value handling.
- Docs and tests: Removes the documented helper opt-out and adds coverage confirming that surrounding marker text cannot disable redaction. All 236 runtime tests pass; varlock and Cloudflare integration builds pass.
gpt-6.1-sol ｜ 𝕏
varlock
@varlock/astro-integration
@varlock/cloudflare-integration
@varlock/expo-integration
@varlock/nextjs-integration
@varlock/nuxt-integration
@varlock/vite-integration
@varlock/native-helper-darwin
@varlock/native-helper-linux-arm64
@varlock/native-helper-linux-x64
@varlock/native-helper-win32-x64
@varlock/1password-plugin
@varlock/akeyless-plugin
@varlock/aws-secrets-plugin
@varlock/aws-sigv4-plugin
@varlock/azure-key-vault-plugin
@varlock/bitwarden-plugin
@varlock/dashlane-plugin
@varlock/doppler-plugin
@varlock/effect-plugin
@varlock/google-secret-manager-plugin
@varlock/hashicorp-vault-plugin
@varlock/infisical-plugin
@varlock/keepass-plugin
@varlock/keeper-plugin
@varlock/kubernetes-plugin
@varlock/pass-plugin
@varlock/passbolt-plugin
@varlock/proton-pass-plugin
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
varlock-website | 59542b1 | Commit Preview URL Branch Preview URL |
Nov 02 2026, 05:18 PM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
revealSensitiveConfig()fromvarlock/env,varlock/auto-initand@varlock/cloudflare-integration/init.It marked a value as revealed by wrapping it in a fixed
👁marker, and redaction skipped any match with those characters on either side. Text logged next to a secret could supply the same characters and switch off redaction for it. Rather than make the marker unguessable, this drops the helper and the marker handling it needed (marker stripping at the last output layer, holding back partial markers in stream redaction).To print a sensitive value on purpose, use
varlock revealrather than logging in code.Merge with the next major.