Repository navigation
Detect Python ENV.KEY and os.environ.get() reads in varlock audit - #1269
Merged
Merged
Conversation
Contributor
|
The changes in this PR will be included in the next version bump.
|
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes across the Python audit scanner, generated module, reserved-key filtering, and accompanying documentation.
- Python reads: Detects
ENV.KEYattribute access andos.environ.get()calls. - Generated module: Replaces the example attribute with
ENV.<KEY>to avoid a phantom audit reference. - Internal keys: Excludes
_VARLOCK_*and__VARLOCK_*from missing-schema reporting and schema inference. - Documentation: Updates supported Python syntax and records the patch release behavior.
Validation: 168 tests passed across scanner, well-known-key, type-generation, Python-emitter, and scan-command coverage. The full suite and website build were not run.
gpt-6.1-sol ｜ 𝕏
Contributor
📦 Bundle size
dist/ only; native binaries are versioned separately and not counted here. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
varlock-website | 6423894 | Commit Preview URL Branch Preview URL |
Nov 02 2026, 05:26 PM |
varlock
@varlock/astro-integration
@varlock/cloudflare-integration
@varlock/nuxt-integration
@varlock/vite-integration
@varlock/native-helper-darwin
@varlock/native-helper-linux-arm64
@varlock/native-helper-linux-x64
@varlock/native-helper-win32-x64
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1266.
varlock auditdidn't recognizeENV.KEYattribute access in Python (the accessor@generatePythonEnvemits), so every item read that way was reported as unused.ENV.KEYandos.environ.get("KEY")env.pydocstring usesENV.<KEY>instead ofENV.MY_KEY, so the scan of the generated file doesn't report a phantomMY_KEY__VARLOCK_*/_VARLOCK_*are treated as well-known keys, so the generated file'sos.environ.get("__VARLOCK_ENV")isn't reported as missing from the schema