Repository navigation
fix: skip notarization/native builds when not publishing - #677
Merged
Merged
Conversation
- Add `bumpy ci plan` preflight job to determine if release workflow
will publish or just create/update a version PR
- Gate macOS build, notarize, and Rust build jobs on mode == 'publish'
- Fix concurrency control to use `bumpy-release` group with
cancel-in-progress: false (queue rather than cancel)
- Update @varlock/bumpy to ^1.7.0 for ci plan support
- Fix publishTargets filter for new object shape ({ type: 'npm' })
Gate build/notarize/download jobs on varlock being in the release plan, not just on any publish. Other packages don't need native binaries. Uses exact match on comma-separated packages list to avoid matching @varlock/* scoped packages.
Use fromJSON(json).packageNames with contains() for exact array element matching instead of grep on comma-separated string. Drop unused packages output.
Replace default CodeQL setup with a custom workflow that: - Always runs JS/TS and Actions analysis (cheap) - Only runs Swift analysis when encryption-binary-swift/ changes - Only runs Rust analysis when encryption-binary-rust/ changes - On push to main and scheduled runs, scans all languages
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
bumpy ci plan only reads bump files and checks the registry — it doesn't need node_modules installed.
Merge two separate check jobs into one, use GitHub API instead of git clone with fetch-depth: 0 to detect changed files. No checkout needed for the check step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bumpy ci planpreflight job to the release workflow to determine whether bumpy will publish or just create/update a version PRmode == 'publish'bumpy-releasegroup withcancel-in-progress: false(queues rather than cancels, per bumpy docs)@varlock/bumpyfrom ^1.5.1 to ^1.7.0 forci plansupportpublishTargetsfilter incheck-release-packages.tsfor the new object shape ({ type: 'npm' }instead of'npm')Test plan
version-prornothing, and build/notarize jobs are skippedpublish, build/notarize jobs run, and publish succeeds