Repository navigation
fix: include plugin loading errors in DataSource.errors getter - #713
Merged
Merged
Conversation
The unified error handling refactor (#708) moved error storage to _errors arrays but the DataSource.errors getter didn't include plugin loading errors (stored on Plugin objects, not in _errors). This caused checkForSchemaErrors to miss plugin load failures, so legacy plugins showed a generic validation error instead of the migration message.
Contributor
|
The changes in this PR will be included in the next version bump.
|
Test fixtures inherit the repo root's bunfig.toml which sets minimumReleaseAge=86400. This blocks installs of recently published packages (e.g. vite@8.0.14), causing bun to hang and the CI job to fail on timeout. Write a local bunfig.toml in each fixture to zero out the age gate while keeping the security scanner active.
commit: |
…ping On Windows with shell=true, the double quotes inside the node -e argument get consumed by cmd.exe, causing a syntax error. Single quotes work in both JS and cmd.exe.
When loadEnvConfig fails in dev mode (e.g., invalid schema), return combinedEnv with initialEnv instead of empty object. Next.js v15's turbopack exits cleanly when combinedEnv is empty (missing NODE_ENV etc.), preventing the dev server from staying alive for hot-reload.
…ss both change Previously, harness file changes triggered an early exit that ran all integrations in quick mode, even when an integration's own package also changed. This caused the nextjs v15 dev server test to be skipped in PR #708 where both the harness and @varlock/nextjs-integration changed.
Vitest sets NODE_ENV=test which gets inherited by spawned dev servers. Next.js v15's turbopack exits cleanly (code 0) when NODE_ENV=test combined with invalid config. Override to development since dev server tests should run in development mode regardless of the test runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_errorsarrays but theDataSource.errorsgetter didn't include plugin loading errors (stored onPluginobjects, not in_errors)checkForSchemaErrorsto miss plugin load failures, so legacy plugins showed a generic "Configuration is currently invalid" validation error instead of the helpful migration messageloadingError(which already checks plugins) in theerrorsgetter when not already presentFixes the smoke test failure in #712.
Test plan
binary-plugin.test.ts > legacy plugin using implicit global shows migration errorpasses locallysmoke-testslabel