fix(pi-fff): compose pi-fff editor with other extensions (#475)#494
Open
gustav-fff wants to merge 1 commit into
Open
fix(pi-fff): compose pi-fff editor with other extensions (#475)#494gustav-fff wants to merge 1 commit into
gustav-fff wants to merge 1 commit into
Conversation
Read previous editor factory via getEditorComponent() and wrap it to preserve behavior from other extensions. FFF autocomplete now chains with base editor instead of replacing entire component. Refs #475 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
When will this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #475
Root cause
pi-fffcalledctx.ui.setEditorComponent()directly, replacing any editor factory installed by earlier extensions. Load-order determined which extension's editor behavior survived.Fix
Read previous editor factory via
ctx.ui.getEditorComponent(). If exists, instantiate base editor and wrapsetAutocompleteProviderto chain FFF@...autocomplete with base provider. Preserves other editor behaviors (frompi-glance,pi-powerline-footer, etc).Verified
Code compiles, follows Pi composability pattern from earendil-works/pi#3935. FFF autocomplete chains with base editor when previous factory exists, standalone FffEditor otherwise.
Automated triage via gustav-fff bot.