Use composable autocomplete provider instead of replacing the editor#570
Merged
dmtrKovalenko merged 1 commit intoJun 5, 2026
Merged
Conversation
Owner
|
@SamuelLHuber do you have any objections? |
Owner
|
@gustav-fff review this PR |
Collaborator
|
looks good reading it. will test the branch now |
SamuelLHuber
approved these changes
Jun 4, 2026
Collaborator
SamuelLHuber
left a comment
There was a problem hiding this comment.
good one. tested and verified locally on my machine too
Collaborator
|
[triage-bot] DIRECTED: LGTM. Composition via Notes (non-blocking):
Tests pass: Honk-Honk 🪿 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes
pi-fffto provide its FFF-backed@file mentions through Pi's composable autocomplete provider API instead of replacing theeditor component.
The current implementation installs a custom editor with
ctx.ui.setEditorComponent(...)only to customize autocomplete behavior. That givespi-fffownership of the whole editor surface, even though the extension only needs to contribute file mention suggestions.Using
ctx.ui.addAutocompleteProvider(...)keeps the same@mention functionality while allowingpi-fffto compose cleanly with other editorextensions.
Changes
FffEditorwrapper.ctx.ui.setEditorComponent(...).@mentions withctx.ui.addAutocompleteProvider(...).Testing
cd packages/pi-fff && bun test test/cd packages/fff-node && npm run buildcd packages/pi-fff && bun run typecheckgit diff --check