Add server shutdown to close listeners on migration exit#8
Open
dnovitski wants to merge 1 commit into
Open
Conversation
- Add Close() method to Server to close unix and TCP listeners - Call server.Close() via defer alongside RemoveSocketFile() in both Migrate() and Revert() paths - Fix Accept loops to exit cleanly when listener is closed instead of logging errors in a tight loop Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix server listener leak: Accept loops and listeners are never closed when migration completes.
Changes
Close()method toServerthat closes both unix and TCP listenersserver.Close()via defer in bothMigrate()andRevert()pathsImpact
Previously, every migration with
--serve-socket-fileor--serve-tcp-portleft goroutines blocked inAccept()and leaked file descriptors until process exit.