Fix MySQL compatibility: EscapeName backticks, REPLICATION REPLICA#9
Open
dnovitski wants to merge 1 commit into
Open
Fix MySQL compatibility: EscapeName backticks, REPLICATION REPLICA#9dnovitski wants to merge 1 commit into
dnovitski wants to merge 1 commit into
Conversation
- Escape embedded backticks in EscapeName by doubling them, preventing broken SQL identifiers (builder.go) - Accept REPLICATION REPLICA privilege in grant check for MySQL 8.4+ compatibility, where REPLICATION SLAVE was renamed (inspect.go) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two MySQL compatibility fixes:
EscapeName backtick escaping
EscapeName()now doubles embedded backticks before wrapping. Previously, an identifier containing a backtick (e.g.a\b) would produce broken SQL:`a`b`instead of`a``b``.MySQL 8.4 REPLICATION REPLICA privilege
The grant check now accepts both
REPLICATION SLAVEandREPLICATION REPLICA. MySQL 8.4 renamed the privilege, so gh-ost would fail the privilege check on MySQL 8.4+ servers even when the user had the correct permissions.