Shipping tax, insurance and cost don't need to be sent up (if nil)#10
Open
RichGuk wants to merge 1 commit intodnunez24:masterfrom
RichGuk:master
Open
Shipping tax, insurance and cost don't need to be sent up (if nil)#10RichGuk wants to merge 1 commit intodnunez24:masterfrom RichGuk:master
RichGuk wants to merge 1 commit intodnunez24:masterfrom
RichGuk:master
Conversation
These fields are optional and don't need to be sent up.
|
+1 |
Owner
|
Thanks, I'll give the specs a try on my system but this looks fine on the surface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was having trouble getting orders to be marked as shipped because even if these were nil it was defaulting them to zero and then throwing an error about changing costs after an order payment has cleared.
Now, I think these specs are right but I can't get a lot of the tests passing, so if someone with passing tests would like to validate.