Update InfluxDB Docker content.md #2586
Open
+279
−636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and storage configuration
jstirnaman
reviewed
Jun 25, 2025
There was a problem hiding this comment.
- The overview paragraph should stay general for InfluxDB (not specific to InfluxDB 3).
- If
docker-librarydoesn't generate or support a TOC, we need to be clear that the readme contains info for all 3 versions. - We need to make sure we don't lose any existing instructions. I see you're linking to the v1 and v2 docs, which is good, but we need to verify they're comprehensive.
There was a problem hiding this comment.
The sample compose.yaml for all 3 would be nice to have.
MeelahMe
changed the title
jstirnaman
reviewed
Jul 1, 2025
influxdb/content.md
Outdated
| -v $PWD/data:/var/lib/influxdb3 \ | ||
| -e INFLUX_LICENSE_KEY="YOUR_LICENSE_KEY" \ | ||
| influxdb:enterprise serve \ | ||
| --cluster-id cluster1 \ |
There was a problem hiding this comment.
We should have an example using available environment variables, specific for Docker startup (if any) and InfluxDB3 variables. Users will want to source them from a file (.env, for example)
| %%IMAGE%%:1.8 /init-influxdb.sh | ||
| docker run -d -p 8086:8086 \ | ||
| -v $PWD:/var/lib/influxdb \ | ||
| influxdb:1.8 | ||
| ``` |
There was a problem hiding this comment.
For v1 and v2, we should keep the examples with the startup config env variables. Most users will want those.
|
@MeelahMe quay.io is mostly used for internal user testing. Publicly, we
need to point to the official image tags on DockerHub:
https://hub.docker.com/_/influxdb/tags
…On Wed, Jul 2, 2025 at 3:11 PM Jameelah Mercer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In influxdb/content.md
<#2586 (comment)>:
>
-*If you run setup from within the container, InfluxDB stores `influx` CLI [connection configurations](/influxdb/v2/reference/cli/influx/#provide-required-authentication-credentials) in the container's `/etc/influxdb2/influx-configs` file.*
+- **Core:** `quay.io/influxdb/influxdb3:latest` <http://quay.io/influxdb/influxdb3:latest>
@jstirnaman <https://github.com/jstirnaman> Okay, I can change them. Can
you tell me why we should not be pointing to them and where I can find
where to point to?
—
Reply to this email directly, view it on GitHub
<#2586 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABT2AZEBL3SYOLC5V6237D3GQ4IPAVCNFSM6AAAAAB7TQR6ECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSOBQGQ4TIMRRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
jstirnaman
reviewed
Jul 2, 2025
influxdb/content.md
Outdated
| %%IMAGE%%:1.8 | ||
| docker run -d --name influxdb3-core \ | ||
| -v influxdb3-data:/var/lib/influxdb3 \ | ||
| -p 8086:8086 \ |
There was a problem hiding this comment.
...unless you set it explicitly. We should just use the default in this README.
MeelahMe
force-pushed
the
docs/docker-readme-update
branch
from
1e46d19 to
9c1a306
Compare
* Remove references to dedicated ROS distros as final ROS 1 version, Noetic, is now EOL * Redirect primary links to documentation landing page as docs page is more up-to-date and pertinent for users * Remove retired ROS blog - https://www.ros.org/news/2020/01/ros-blog-retired.html * Update OSRF URL redirect * Update example image tag to rolling to avoid docs from becoming stale * Consolidate branding and dated references * Update Q&A links to stackexchange given migration - https://discourse.ros.org/t/planned-migration-of-ros-answers-and-gazebo-answers-to-robotics-stack-exchange/28068 - https://discourse.ros.org/t/new-static-archives-for-ros-and-gazebo-answers/41346 * Simplify cloning overlay source * Simplify use of mixin setting * Split runner and builder stages as example to save on image size as well as on build time using caching * Simplify scripting for dependencies * Lint use of ARGs for readability of each stage * Simplify example cache mount for apt and update rosdep along with apt list to ensure package index is fresh * Update categories for ROS to include additional relevant entries * Shorten derivation script * Use ros-core tag for minimal installer * Stage example image sizes for demos * Simplify naming * Omit cacher from size table to focus on primary targets * Modify and mount custom apt config accounting for included docker-clean default * Simplify RUN directive for apt config * Stage WIP edits * Update package cache before cloning source to avoid running rosdep update for each source change as docker build --no-cache can still be used to force update * Fix use of EOF in Dockerfile * Simply RUN directives * Expand bullet points about optimizations * Expand upon runner vs installer comparison * Linting * Fix grammar and spelling * Linting * Rename stage in apt get example while keeping with uniquely spelled noun that is self descriptive yet unmistakable * Comment on overwriting defaults to persist minimal cache
On Windows, Git may be configured to checkout LF line endings as CRLF, but this breaks shell scripts.
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
MeelahMe
force-pushed
the
docs/docker-readme-update
branch
from
52789b3 to
7b257f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Docker README file to clarify instructions for running the server in a container.
Changes include: