Skip to content

internal/scanner: close output file on encode error#184

Open
Dev-X25874 wants to merge 2 commits into
docker:masterfrom
Dev-X25874:fix/scanner-fd-leak-on-encode-error
Open

internal/scanner: close output file on encode error#184
Dev-X25874 wants to merge 2 commits into
docker:masterfrom
Dev-X25874:fix/scanner-fd-leak-on-encode-error

Conversation

@Dev-X25874

Copy link
Copy Markdown

os.Create opens a file descriptor that is never closed if
json.NewEncoder(f).Encode(stmt) subsequently fails. In a multi-target
scan this leaks one fd per failing target.

Extract the write into a writeStatement helper that defers f.Close,
using a named return so the close error is not silently dropped on the
happy path.

Add unit tests for writeStatement and loadPathFromEnvironment.

@Dev-X25874 Dev-X25874 requested review from a team as code owners May 28, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant