Repository navigation
dockerfile: update to docker v29.0.0 - #3498
Merged
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
thaJeztah
approved these changes
Nov 13, 2025
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM, but left a suggestion
| - worker: "docker@27.5" | ||
| pkg: ./tests | ||
| - worker: "docker+containerd@26.1" # same as docker, but with containerd snapshotter | ||
| - worker: "docker+containerd@27.5" # same as docker, but with containerd snapshotter |
Member
There was a problem hiding this comment.
Wondering if we should include a 25.0 somewhere; 26.x and 27.x are EOL, but 25.0 is maintained by mirantis and AWS
Member
Author
There was a problem hiding this comment.
We chose to keep n-2 for our integration tests to check for regressions with past stables like we do for BuildKit:
buildx/.github/workflows/build.yml
Lines 57 to 59 in 45731b8
But also to check for issues with default Docker version used on GitHub Hosted runners: https://github.com/crazy-max/ghaction-dump-context/actions/runs/19068023635/job/54463406479#step:3:638
Maybe we could add 25 if you think this can be useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3477