feat: add OpenAI support to all single-model demos #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated a2a, adk, crewai, langgraph and spring-ai - Set up so having OPENAI_API_KEY or not selects between OpenAI and DMR - Print the selected model during the container startup - Update all README to include the available options for inference
fiam
force-pushed
the
alberto/enable-open-ai
branch
from
c919463 to
689024c
Compare
a2a/Dockerfile
Outdated
| #!/bin/sh | ||
| set -e | ||
| if test -n "\${OPENAI_API_KEY}"; then | ||
| echo "OPENAI_API_KEY is set, using OpenAI with \${MODEL_NAME}" |
Collaborator
There was a problem hiding this comment.
Actually I think this logic should be pushed back to the model runner, which could act as a proxy to openai
Collaborator
There was a problem hiding this comment.
Not for this PR obviously 😄
Collaborator
Author
There was a problem hiding this comment.
Eventually yes, but that won't be available short term.
Member
|
LGTM! I'm liking this pattern of using the overlays for the different permutations. Nicely done! |
silvin-lubecki
approved these changes
Jul 3, 2025
Contributor
|
Thanks for merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compose.openai.yamlto enable OpenAI