Skip to content

fix(agno): restore MCP functionality #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fiam merged 2 commits into from
Jul 25, 2025
Merged

fix(agno): restore MCP functionality #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a931ee5
fix(agno): restore MCP functionality
fiam Jul 25, 2025
c53f445
fix: add depends_on
fiam Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions agno/agent/playground.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,10 @@ async def create_mcp_tools(tools_list: list[str], entity_type: str) -> list[Tool
transport: str = ""
if gateway_url.startswith("http://") or gateway_url.startswith("https://"):
url = gateway_url
transport = "sse"
print(f"DEBUG: {entity_type} connecting to MCP gateway via SSE {url}")
transport = "streamable-http"
print(
f"DEBUG: {entity_type} connecting to MCP gateway via streamable-http {url}"
)
else:
# Assume it's a TCP endpoint
tcp_endpoint = gateway_url
Expand Down
5 changes: 4 additions & 1 deletion agno/compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ services:
- "7777:7777"
environment:
# point agents at the MCP gateway
- MCPGATEWAY_URL=mcp-gateway:8811
- MCPGATEWAY_URL=http://mcp-gateway:8811
depends_on:
- mcp-gateway
volumes:
Copy link

@realjenius realjenius Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: I think it might benefit from a depends_on: for the mcp-gateway as well.

Copy link
Collaborator Author

@fiam fiam Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was waiting until we settled the healthchecks to add that, but I guess we can add a depends_on today and make it depend on a healthy service later.

Copy link

@realjenius realjenius Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a broader strategy/plan, no worries! I just saw some of the others had it.

Copy link
Collaborator Author

@fiam fiam Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think your idea is right, no worries :-). I've updated it, PTAL.

# mount the agents file
- ./agents.yaml:/agents.yaml
Expand All @@ -34,6 +36,7 @@ services:
# use docker API socket to start MCP servers
use_api_socket: true
command:
- --transport=streaming
# securely embed secrets into the gateway
- --secrets=/run/secrets/mcp_secret
# add any MCP servers you want to use
Expand Down