run: add support --no-build, --pull flags #12032
Open
+61
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
run-configurable-pull-policy
branch
2 times, most recently
from
1f0f5aa
to
abfbd7c
Compare
legobeat
force-pushed
the
run-configurable-pull-policy
branch
2 times, most recently
from
95e5968
to
a675a1e
Compare
ndeloof
reviewed
Aug 5, 2024
legobeat
force-pushed
the
run-configurable-pull-policy
branch
from
a675a1e
to
837e020
Compare
ndeloof
reviewed
Aug 6, 2024
| @@ -81,6 +82,12 @@ func (options runOptions) apply(project *types.Project) (*types.Project, error) | |||
| } | |||
|
|
|||
| target.Tty = !options.noTty | |||
| if options.noBuild { | |||
There was a problem hiding this comment.
why configure build is no-build was requested?
There was a problem hiding this comment.
The idea here is that:
- If
--no-buildis passed, we do not want to build, so clear the existing build configuration from the service. Build.PullandBuild.Tagsmay affect behavior outside of the actual build, so we selectively preserve those.
There was a problem hiding this comment.
@ndeloof Looping back here! Does this makes sense or do you think it should behave differently? Should I add some clarification in comments or docs...?
legobeat
force-pushed
the
run-configurable-pull-policy
branch
from
837e020
to
b1d0495
Compare
legobeat
force-pushed
the
run-configurable-pull-policy
branch
from
b1d0495
to
0694340
Compare
legobeat
force-pushed
the
run-configurable-pull-policy
branch
from
0694340
to
18ce4fc
Compare
legobeat
force-pushed
the
run-configurable-pull-policy
branch
from
18ce4fc
to
3d5a2b1
Compare
legobeat
force-pushed
the
run-configurable-pull-policy
branch
from
3d5a2b1
to
c012a59
Compare
legobeat
force-pushed
the
run-configurable-pull-policy
branch
from
c012a59
to
fed83d8
Compare
Allows setting build- and pull policies for `compose run` like for `docker run` and `compose up`. Signed-off-by: legobt <[email protected]>
legobeat
force-pushed
the
run-configurable-pull-policy
branch
from
fed83d8
to
22efc5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting build- and pull policies for
docker-compose runlike fordocker runanddocker-compose up.