fix: correct repo reference in update-docker-agent-version workflow#3
Conversation
The signed-commit step was referencing docker/cagent-action instead of docker/docker-agent-action. This was a copy-paste artifact from when the workflow was copied from cagent-action, causing the version-bump PR to be created in the wrong repository.
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This single-line fix correctly changes the --repo argument in the signed-commit step from docker/cagent-action to docker/docker-agent-action. The change is accurate — without it, the automated version-bump commits would be written to the wrong (old) repository. No logic errors, security issues, or other problems are introduced.
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This is a targeted, correct fix. The --repo flag in the signed-commit step was pointing to docker/cagent-action (the old repo name) instead of docker/docker-agent-action (the canonical target). The change is accurate: docker/docker-agent-action matches the repository's own identity and the stated migration goal.
The rest of the workflow was also checked — the only remaining docker/cagent-action reference is the pinned uses: docker/cagent-action/setup-credentials@… composite action, which is intentionally still pointing at the old repo (that migration is out of scope for this PR).
No issues found. ✅
… workflow The gh pr list, gh pr edit, and gh pr create commands were missing the --repo docker/docker-agent-action flag. Without it, gh cannot detect the repo due to the authenticating proxy rewriting remote URLs, causing these commands to fail at runtime.
3 participants
Summary
The
signed-commitstep in.github/workflows/update-docker-agent-version.ymlwas referencingdocker/cagent-actioninstead ofdocker/docker-agent-action. This was a copy-paste artifact from when the workflow was copied from thecagent-actionrepo.As a result, any version-bump PR triggered by this workflow would be created in the wrong repository (
docker/cagent-action) rather than in this repo (docker/docker-agent-action).Change