fix(review-pr): remove auto-review, require explicit reviewer request only#30
Closed
derekmisler wants to merge 1 commit into
Closed
fix(review-pr): remove auto-review, require explicit reviewer request only#30derekmisler wants to merge 1 commit into
derekmisler wants to merge 1 commit into
Conversation
… only Reviews now only run when docker-agent is explicitly requested as a reviewer (review_requested). The previous auto-review on opened/ready_for_review is removed across all templates, docs, and the reusable workflow. Changes: - .github/workflows/pr-review-trigger.yml: new canonical fork-PR trigger template with only review_requested, concurrency group, fork-only if condition (head.repo.fork && sender.type != 'Bot'), and bot-actor skip - .github/workflows/review-pr.yml: remove the auto-review pull_request branch (action != review_requested) from the review job if condition; update trigger-type classification comment - review-pr/README.md: remove all auto-review language; update workflow snippets, trigger table, flow diagram, and defense-in-depth section - .agents/skills/add-pr-reviewer-to-repo/SKILL.md: remove trigger mode section (Modes A/B), update all YAML examples and audit checklist to review_requested only; update fork trigger template with concurrency group and if condition
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The changes look correct. This PR cleanly removes auto-review triggers (opened, ready_for_review) and restricts triggering to explicit review_requested events only.
Reviewed areas:
.github/workflows/pr-review-trigger.yml— newif:guard onsave-contextjob correctly handles bothpull_requestandpull_request_review_commentevents. Thepull_request_review_commentwebhook payload includes a nestedpull_requestobject (per GitHub docs), sogithub.event.pull_request.head.repo.forkis valid and populated for both event types. ✅.github/workflows/review-pr.yml— removed auto-review branch fromif:condition. Logic is consistent with the new explicit-only model. ✅review-pr/README.md— documentation updated to reflectreview_requested-only model. Examples are accurate. ✅.agents/skills/add-pr-reviewer-to-repo/SKILL.md— simplified documentation template matches the actual workflow guard semantics. ✅
No bugs found in the changed code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviews now only run when
docker-agentis explicitly requested as a reviewer (review_requested). Auto-review onopened/ready_for_reviewis removed everywhere.Changes
.github/workflows/pr-review-trigger.yml(new canonical fork-PR trigger template):review_requestedtrigger type (removedopened,ready_for_review)if: github.event.pull_request.head.repo.fork && github.event.sender.type != 'Bot'— only runs for fork PRs, skips Bot-account senders early.github/workflows/review-pr.yml:pull_requestbranch (action != 'review_requested') from thereviewjobif:conditionreview-pr/README.md:review_requestedonly.agents/skills/add-pr-reviewer-to-repo/SKILL.md:review_requestedonlyifconditionreview_requestedonly