-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update api docs links #23933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api docs links #23933
Conversation
❌ Deploy Preview for docsdocker failed. Why did it fail? →
|
5a64337 to
1596996
Compare
Signed-off-by: MohammadHasan Akbari <[email protected]>
|
Updating LGTM, but wondering; did some redirect break? It looks like this URL was valid before 🤔 |
It seems that the API documentation for some versions is no longer available: |
|
Oh! You're right, it's probably because it was linking to a deprecated API version. We should probably add a redirect for those as well, and link to the overview (or redirect to "latests") 🤔. That can definitely be done as a follow up though @dvdksn any thoughts? |
|
@gtardif is any of this content generated? (if so, should these links be updated in a source repository somewhere?) |
|
@thaJeztah hmm yeah we should have redirects for these now-removed pages. I think these slipped through our link checker because they're ignored: Line 11 in 8725611
And the reason they're ignored, iirc, is because we can't check these links without javacript, since they're resolved by redoc. Opened #23938 |
Signed-off-by: MohammadHasan Akbari <[email protected]>
|
I have applied the requested changes. |
dvdksn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Looks like netlify is hitting GitHub API rate limits 🤔 |
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM though, thanks!
Description
Corrected API documentation URLs that were pointing to incorrect locations.
Related issues or tickets
Reviews