Fix truncated DOCKER_ACCOUNT variable in Circle CI example#25253
Merged
Conversation
The Circle CI build_push and build_cache jobs in the Build Cloud CI docs used a truncated $DOCKER_ variable in the docker login command, which expands to empty and breaks authentication. Use $DOCKER_ACCOUNT to match the rest of the file. Fixes docker#25214 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
reviewed
Jun 3, 2026
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The fix correctly replaces both instances of the truncated $DOCKER_ variable with $DOCKER_ACCOUNT in the Circle CI example, making the docker login command functional in both the build_push and build_cache jobs. The change is minimal, accurate, and consistent with the surrounding code.
craig-osterhout
approved these changes
Jun 3, 2026
thaJeztah
reviewed
Jun 3, 2026
| @@ -201,7 +201,7 @@ jobs: | |||
| curl --silent -L --output ~/.docker/cli-plugins/docker-buildx $BUILDX_URL | |||
| chmod a+x ~/.docker/cli-plugins/docker-buildx | |||
|
|
|||
| - run: echo "$DOCKER_ACCESS_TOKEN" | docker login --username $DOCKER_ --password-stdin | |||
| - run: echo "$DOCKER_ACCESS_TOKEN" | docker login --username $DOCKER_ACCOUNT --password-stdin | |||
Member
There was a problem hiding this comment.
not new, but we should probably add quotes as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Circle CI example in the Build Cloud CI docs used a truncated
$DOCKER_variable in thedocker logincommand in both thebuild_pushandbuild_cachejobs. As written,$DOCKER_expands to an empty string, so the login fails. This changes both occurrences to$DOCKER_ACCOUNT, matching the very next line in each job (${DOCKER_ACCOUNT}) and every other CI example in the file.Related issues
Closes #25214
🤖 Generated with Claude Code