Vendor latest AI Governance OpenAPI spec#25265
Conversation
Sync the AI Governance Policy API reference with the upstream spec from docker/governor-services#242. Wraps the ListPolicies response data under a `data` object, adds the updatePolicy and deletePolicy endpoints, migrates policy scope from profiles to teams, and switches rule/policy updates to application/json. Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Vendoring sync looks clean. The spec is valid, all new endpoints (PATCH/DELETE policy) are well-formed, the ListPolicies response wrapping is consistent throughout examples and schemas, and the profiles → teams migration is applied uniformly. Two minor wording nits flagged inline — vestigial multi-dimension language in ScopePatch and updatePolicy from when scope had both profiles and teams sub-fields; safe to ignore or clean up in a follow-on.
| Partially updates a policy's metadata. Only fields present in the | ||
| request body are updated; absent fields are left unchanged. The `scope` | ||
| object is patched per sub-field: sending `teams` replaces that list, | ||
| while an omitted sub-field is left untouched and an empty list clears |
There was a problem hiding this comment.
[LOW] Vestigial "sub-field" language from when scope had multiple dimensions
The phrase "an omitted sub-field is left untouched" hints at multiple sub-fields, but scope now has only one (teams). Consider simplifying: "omitting teams leaves it unchanged; an empty list clears it (org-wide)."
| description: > | ||
| Per-sub-field patch of a policy's scope. An omitted sub-field is left | ||
| unchanged; a present list replaces that dimension, and an empty list | ||
| clears it (making the policy org-wide for that dimension). |
There was a problem hiding this comment.
[LOW] Vestigial "for that dimension" language implies multiple dimensions
The phrase "clears it (making the policy org-wide for that dimension)" uses "dimension" as though there are several, but ScopePatch now has only teams. Consider "clears it (making the policy org-wide)" or "clears the teams list (making the policy org-wide)."
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR vendors the latest AI Governance OpenAPI spec. The YAML is syntactically valid, the new PATCH (updatePolicy) and DELETE (deletePolicy) endpoints are well-documented, and the schema changes (ListPolicies response envelope, teams-based scope) are consistent with the rest of the spec. No documentation style violations were found in the added description fields. No issues require attention.
3 participants
Summary
Syncs the AI Governance Policy API reference with the upstream spec.
Implementation PR: https://github.com/docker/governor-services/pull/242
Generated by Claude Code