-
Notifications
You must be signed in to change notification settings - Fork 12
chore: Add installation instructions and fix dependencies #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: Add installation instructions and fix dependencies #176
Conversation
|
✅ DCO Check Passed Thanks @nikolasrieble, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, Nikolas Rieble <[email protected]>, hereby add my Signed-off-by to this commit: 93b0e93 I, Nikolas Rieble <[email protected]>, hereby add my Signed-off-by to this commit: 59058d1 Signed-off-by: Nikolas Rieble <[email protected]>
|
@nikolasrieble Thanks for making an effort here. This repo definitely lacks documentation on the installation process. I would make certain changes though:
Would you be up to iterate on this? |
Fully agree with (1). My naive proposal would be: Lets merge this and then iterate, i.e. do another PR to add (2), and fix (1) in yet another. Often making smaller steps ends up being faster. |
The core change here are (1) installation instructions to the README.
Following the instructions myself, the initial command
failed with
uv groups should be optional. If something is needed for a basic
--helpcommand, it should be a base dependency. To resolve this, I (2) move two dependencies from the hyperscalar group into the base group.And finally, (3) with
uv syncwe update the uv lockfile.This PR closes #168