Added new check to ensure composite indexes are dropped ahead of remo… #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/safe-pg-migrations/plugins/statement_insurer/remove_column_index.rb
Outdated
Show resolved
Hide resolved
lib/safe-pg-migrations/plugins/statement_insurer/remove_column_index.rb
Outdated
Show resolved
Hide resolved
CharlotteFeather
force-pushed
the
explicitly-ensure-indexes-removed
branch
from
e7f0ecb to
c67f764
Compare
CharlotteFeather
force-pushed
the
explicitly-ensure-indexes-removed
branch
from
c67f764 to
c800962
Compare
CharlesDelannoy
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent composite indexes being dropped by accident. A check has been added to ensure no composite index is present before removing the column. Indexes on the column only do not need to be removed before dropped the column.
In addition, there were a few rubocop failures fixed in this PR on other files.