Timeout for PDF extraction from OpenOffice supported document format. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because when we extract_pdf() document more than 400-500 pages,
the JODConverter fails with exception:
Exception in thread "main" org.artofsolving.jodconverter.office.OfficeException:
task did not complete within timeout at org.artofsolving.jodconverter.office.PooledOfficeManager.execute...
|
vote for supporting timeout option. 👍 |
|
Me too. Have run into the issue before. Very heavy docs can take almost 5min to convert to pdf. |
|
+1 here too; what are the chances this pull request will be granted? |
|
+1 Has this been resolved yet? I am running into this problem as well. Anything over 1.5 mB on .doc format seems to timeout along with a lot of pdfs. |
| @@ -94,6 +94,9 @@ def parse_options | |||
| opts.on('--no-clean', 'disable cleaning of OCR\'d text') do |c| | |||
| @options[:clean] = false | |||
| end | |||
| opts.on('-t', '--timeout [SEC]', 'Timeout for PDF extraction from OpenOffice document format (default is 1 hour)') do |t| | |||
There was a problem hiding this comment.
Perhaps change this message to "Timeout for PDF extraction from OpenOffice supported document format" so as not to lead people into thinking the flag will only apply to OpenOffice files and not .doc, .xlsx
There was a problem hiding this comment.
@alxndrmlr, will do thanks
doxavore
pushed a commit
to ebp/docsplit
that referenced
this pull request
Apr 25, 2014
Original work by documentcloud#34 with modification to not use a default timeout (causing no change from existing functionality).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because when we extract_pdf() from document more than 400-500 pages,
the JODConverter fails with exception:
Exception in thread "main" org.artofsolving.jodconverter.office.OfficeException: task did not complete within timeout at org.artofsolving.jodconverter.office.PooledOfficeManager.execute(PooledOfficeManager.java:88) at
org.artofsolving.jodconverter.office.ProcessPoolOfficeManager.execute(ProcessPoolOfficeManager.java:78) at org.artofsolving.jodconverter.OfficeDocumentConverter.convert(OfficeDocumentConverter.java:78) at org.artofsolving.jodconverter.OfficeDocumentConverter.convert(OfficeDocumentConverter.java:69) at org.artofsolving.jodconverter.cli.Convert.main(Convert.java:118) Caused by: java.util.concurrent.TimeoutException at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228) at java.util.concurrent.FutureTask.get(FutureTask.java:91) at org.artofsolving.jodconverter.office.PooledOfficeManager.execute(PooledOfficeManager.java:85) ...
The new JODConverter 3.0b4 getting timeout param. The problem is solved.
I don't know if timeout should be hardcoded, or if it should be documented Docsplit's option. I did both in separate commits.