feat(resume): use versioned export filenames - #10
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR standardizes single-resume export naming by introducing a shared, sanitized, versioned base filename (name-v<version>) and applying it consistently across JSON exports, print-to-PDF titles, and PNG exports.
Changes:
- Added a filename-part sanitization helper and a shared
getResumeExportFileBaseName()utility. - Updated print-to-PDF behavior to use the versioned base name via
document.title. - Updated JSON and PNG export download filenames to use the same versioned base name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+224
to
+226
| const version = | ||
| sanitizeFileNamePart(document.version).replace(/^v+/i, "") || "1.0.0"; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name_iResume.jsontoname-vversion.jsonname-vversionbase for PDF print titles and PNG exportsvprefixNotes
iresume-user-data-date.jsonbecause those are library backups, not single-resume exportsChecks