Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR is a broad “1.0.0 release” rollout that evolves iResume from a single-resume editor into a local-first resume workbench with a resume library, richer appearance controls (themes / density / layout options), safer link handling in markdown, and optional GitHub-encrypted cloud sync.
Changes:
- Added resume library data model + manager UI (create/duplicate/delete, tags, versions) and expanded editor/preview capabilities for section-level preferences and interactions.
- Introduced multiple new themes and appearance controls (font size, page margin, preview zoom, content density/layout styles), along with supporting CSS/typing updates.
- Implemented URL normalization/sanitization and added GitHub OAuth + encrypted Gist sync (client + API routes), plus README refresh.
Reviewed changes
Copilot reviewed 28 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/url.ts | Adds normalizeSafeUrl helper to normalize/sanitize user-provided URLs. |
| src/utils/markdown.tsx | Uses normalizeSafeUrl to prevent unsafe markdown links from rendering as anchors. |
| src/types/theme.ts | Extends theme typing to support new theme IDs and richer layout/style controls. |
| src/types/resume.ts | Extends resume typing (e.g., project date, section icon visibility type). |
| src/index.css | Adds scrollbar utilities, panning cursor styles, print tweaks, and font scaling hooks. |
| src/data/themes.ts | Adds many new themes and theme helpers (IDs, normalization, defaults). |
| src/data/resumeStyle.ts | Introduces appearance preference models + normalization and font/margin option helpers. |
| src/data/resumeLibrary.ts | Adds resume library/document model plus normalization and version/tag helpers. |
| src/data/resumeData.ts | Adds normalization utilities for resume data + section icon visibility helpers. |
| src/data/resumeBackup.ts | Adds backup model/normalization to support import/export of enriched appearance data. |
| src/data/previewZoom.ts | Adds zoom option constants + normalization and stepper helpers. |
| src/data/initialData.ts | Updates initial sample data to match new types (e.g., project date). |
| src/data/cloudSync.ts | Adds encrypted payload envelope + GitHub Gist sync client functions. |
| src/components/ToggleSwitch.tsx | New reusable toggle switch component. |
| src/components/ThemePicker.tsx | Revamps theme picker into a portal modal with favorites support. |
| src/components/ResumePreview.tsx | Major preview overhaul: density/layout styles, safer links, section icon support, click-to-edit hooks. |
| src/components/ResumeManager.tsx | Adds resume library/workbench manager UI and cloud sync / user-data settings modal. |
| src/components/ResumeEditor.tsx | Restructures editor into “structure/details” panels with richer section editing UX. |
| src/components/ResumeDisplayPreferencesEditor.tsx | New UI to edit per-section display preferences (dates, tags, list styles, etc.). |
| src/components/PreviewZoomControl.tsx | New zoom stepper control for preview scaling. |
| src/components/PageMarginControl.tsx | New page margin stepper control. |
| src/components/FontSizeControl.tsx | New font size stepper control. |
| src/assets/react.svg | Removes unused default React asset. |
| README.md | Refreshes README for 1.0.0 and new feature set. |
| package.json | Adds html-to-image dependency. |
| bun.lock | Locks html-to-image dependency addition. |
| api/github/sync-key.js | Adds API route to derive a deterministic AES sync key from GitHub identity. |
| api/github/oauth.js | Adds API route to exchange GitHub OAuth code for access token. |
| .env.example | Documents required GitHub OAuth env vars for cloud sync. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+500
to
+505
| export const getDefaultSectionIconVisibility = ( | ||
| themeId: ThemeId, | ||
| ): SectionIconVisibility => { | ||
| void themeId; | ||
| return createSectionIconVisibility(true); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checks