Skip to content

AdjFloat._ad_add etc should return AdjFloat not float #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JHopeCollins wants to merge 4 commits into
base: master
Choose a base branch
from
Open

AdjFloat._ad_add etc should return AdjFloat not float #244

JHopeCollins wants to merge 4 commits into from

Conversation

@JHopeCollins
Copy link
Contributor

@JHopeCollins JHopeCollins commented Feb 5, 2026

Using super() here means that these methods currently return float, whereas the _ad_op API states it should return the same type as self.

@JHopeCollins JHopeCollins self-assigned this Feb 5, 2026
@JHopeCollins JHopeCollins added the bug Something isn't working label Feb 5, 2026
connorjward
connorjward reviewed Feb 5, 2026
View reviewed changes
jrmaddison
jrmaddison reviewed Feb 6, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrmaddison jrmaddison jrmaddison left review comments

@connorjward connorjward connorjward left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@JHopeCollins JHopeCollins

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JHopeCollins @jrmaddison @connorjward