Skip to content

Use Node 24 in GH actions #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eric-richardson1 wants to merge 2 commits into from
Closed

Use Node 24 in GH actions #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bacf9e0
fix test names resetting to old name when backspacing
eric-richardson1 Nov 11, 2025
6b47fd8
Use node 24 in GH actions
eric-richardson1 Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cd-release-dmg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ jobs:
platform: dmg
token: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version: "latest"
node-version: "24"

- name: Install dependencies
uses: ./.github/actions/install-dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cd-release-linux.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ jobs:
platform: linux
token: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version: "latest"
node-version: "24""

- name: Install dependencies
uses: ./.github/actions/install-dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cd-release-mas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ jobs:
platform: mas
token: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version: "latest"
node-version: "24"

- name: Install dependencies
uses: ./.github/actions/install-dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cd-release-windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ jobs:
platform: win
token: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version: "latest"
node-version: "24"

- name: Install dependencies
uses: ./.github/actions/install-dependencies
Expand Down
2 changes: 1 addition & 1 deletion web/renderer/components/pageComponents/DatabasePage/ForTests/TestItem/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<FaChevronRight className={css.expandIcon} />
<input
className={css.editableTestName}
value={editingName || test.testName}
value={editingName ?? test.testName}

Check failure on line 54 in web/renderer/components/pageComponents/DatabasePage/ForTests/TestItem/index.tsx

View workflow job for this annotation

GitHub Actions / ci 

Unnecessary conditional, expected left-hand side of `??` operator to be possibly null or undefined
onChange={e => handleTestNameEdit(test.testName, e.target.value)}
onFocus={() => handleTestNameEdit(test.testName, test.testName)}
onBlur={() => handleTestNameBlur(test.testName)}
Expand Down
Loading